Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update docstring for lifecycle_rules to match generator behavior #841

Merged
merged 2 commits into from
Aug 12, 2022
Merged

docs: Update docstring for lifecycle_rules to match generator behavior #841

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4d3853
Fix: Update docstring for lifecycle_rules to match generator behavior
andrewsg Aug 11, 2022
88ff6fe
Merge branch 'main' into lifecycle-rules-docstring
parthea Aug 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions google/cloud/storage/bucket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2273,12 +2273,12 @@ def lifecycle_rules(self):
.. note::
The getter for this property returns a list which contains
The getter for this property returns a generator which yields
*copies* of the bucket's lifecycle rules mappings. Mutating the
list or one of its dicts has no effect unless you then re-assign
the dict via the setter. E.g.:
output dicts has no effect unless you then re-assign the dict via
the setter. E.g.:
>>> rules = bucket.lifecycle_rules
>>> rules = list(bucket.lifecycle_rules)
>>> rules.append({'origin': '/foo', ...})
>>> rules[1]['rule']['action']['type'] = 'Delete'
>>> del rules[0]
Expand Down