Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add page_size to list_blobs, list_buckets #520

Merged

Conversation

ryanyuan
Copy link
Contributor

@ryanyuan ryanyuan commented Jul 22, 2021

Adding page_size to list_blobs() and list_buckets() to have better support page_iterator.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #425 🦕

@ryanyuan ryanyuan requested a review from a team July 22, 2021 13:04
@ryanyuan ryanyuan requested a review from a team as a code owner July 22, 2021 13:04
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Jul 22, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 22, 2021
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Jul 22, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 22, 2021
@tseaver tseaver merged commit c5f4ad8 into googleapis:master Jul 22, 2021
@tseaver
Copy link
Contributor

tseaver commented Jul 22, 2021

@ryanyuan Thanks very much for the patch!

tseaver added a commit that referenced this pull request Aug 2, 2021
Transitive dependency resolution breaks unit tests under Python 3.6
following PR #520.

Pin minima for those ranges explicitly when testing under Python 3.6.

Closes #529.
gcf-merge-on-green bot pushed a commit that referenced this pull request Aug 5, 2021
#530)

Transitive dependency resolution breaks unit tests under Python 3.6
following PR #520.

Pin minima for those ranges explicitly when testing under Python 3.6.

Closes #529.
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
googleapis#530)

Transitive dependency resolution breaks unit tests under Python 3.6
following PR googleapis#520.

Pin minima for those ranges explicitly when testing under Python 3.6.

Closes googleapis#529.
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
googleapis#530)

Transitive dependency resolution breaks unit tests under Python 3.6
following PR googleapis#520.

Pin minima for those ranges explicitly when testing under Python 3.6.

Closes googleapis#529.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/python-storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

max_results argument of Client.list_blobs does not behave correctly
4 participants