-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add / use 'Client._delete_resource' method #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
Issues related to the googleapis/python-storage API.
label
May 10, 2021
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
May 10, 2021
tseaver
force-pushed
the
38-refactor-client-_delete_resource
branch
3 times, most recently
from
May 10, 2021 19:44
54c1d2d
to
6244df0
Compare
tseaver
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
May 10, 2021
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
May 10, 2021
Also, forward 'retry' through when deleting blobs during 'Bucket.delete'. Toward #38.
tseaver
force-pushed
the
38-refactor-client-_delete_resource
branch
from
June 7, 2021 19:27
6244df0
to
7525c66
Compare
chrisrossi
approved these changes
Jun 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
tseaver
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jun 7, 2021
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jun 7, 2021
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
Also, forward 'retry' through when deleting blobs during 'Bucket.delete'. Toward googleapis#38.
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
Also, forward 'retry' through when deleting blobs during 'Bucket.delete'. Toward googleapis#38.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: storage
Issues related to the googleapis/python-storage API.
cla: yes
This human has signed the Contributor License Agreement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toward #38.
Note: this PR is based on afbf690 from PR #441. I will rebase to master when that PR lands.Done.