-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move methods to client class #311
refactor: move methods to client class #311
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@tswast In the bug you said, "we need to update samples for moved methods before deprecating the old ones." Is this change okay as-is, or do we need to make this change without the deprecation warning first, then update samples, then add the deprecation warning? |
If it helps you find the samples that need to be updated, I'm okay merging this PR first. It's just a bad look if we have samples on cloud.google.com that show deprecation warnings. |
I agree. But we can't update the sample without pushing part of this change, so @HemangChothani Let's omit the deprecation warning for now and open an issue to update the samples, then add the deprecation warning in that order. |
@andrewsg Opend an issue GoogleCloudPlatform/python-docs-samples#5031 to update the samples. |
@andrewsg I have opend an issue to update sample GoogleCloudPlatform/python-docs-samples#5031 in python-docs-sample repo , but i didn't find any sample needs to update, should i open issue in |
@andrewsg and @HemangChothani, I replied to the issue. We are only missing updates for download_to_filename. |
@frankyn we have moved
Also update the method call from |
Why was only download_to_file updated but not download_to_filename? |
Document mentioned in issue #38, found |
Fixes #38