Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop use of 'pytz' in examles / tests #533

Closed
2 tasks
tseaver opened this issue Aug 5, 2021 · 0 comments · Fixed by #534
Closed
2 tasks

Drop use of 'pytz' in examles / tests #533

tseaver opened this issue Aug 5, 2021 · 0 comments · Fixed by #534
Assignees
@tseaver
Labels
api: storage Issues related to the googleapis/python-storage API. type: cleanup An internal cleanup or hygiene concern.

Comments

@tseaver
Copy link
Contributor

tseaver commented Aug 5, 2021

Except under Python 2.7, current versions of google-api-core and google-cloud-core no longer use or depend on the pytz library, preferring instead to use the stdlib's datetime.timezone and datetime.timezone.utc.

  • Add testing with the 2.0.0b1 versions of google-api-core, google-cloud-core, and google-auth under Python 3.9.
  • Drop any use of pytz in tests or examples.
@tseaver tseaver added the type: cleanup An internal cleanup or hygiene concern. label Aug 5, 2021
@tseaver tseaver self-assigned this Aug 5, 2021
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Aug 5, 2021
tseaver added a commit that referenced this issue Aug 5, 2021
@tseaver
chore: drop use of 'pytz' in tests / examples
54d4d03 
Current (pre-)releases of 'google-api-core' and 'google-cloud-core' no
longer use or depend on 'pytz'.

Add '--pre' to constraints file for Python 3.9, to allow testing
against those versions.

Closes #533.
@tseaver tseaver mentioned this issue Aug 5, 2021
Merged
tseaver added a commit that referenced this issue Aug 18, 2021
@tseaver
chore: drop use of 'pytz' in tests / examples (#534)
0f17595 
Current (pre-)releases of 'google-api-core' and 'google-cloud-core' no
longer use or depend on 'pytz'.

Closes #533.
cojenco pushed a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
@tseaver @cojenco
chore: drop use of 'pytz' in tests / examples (googleapis#534)
a2148ba 
Current (pre-)releases of 'google-api-core' and 'google-cloud-core' no
longer use or depend on 'pytz'.

Closes googleapis#533.
cojenco pushed a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
@tseaver @cojenco
chore: drop use of 'pytz' in tests / examples (googleapis#534)
4907e96 
Current (pre-)releases of 'google-api-core' and 'google-cloud-core' no
longer use or depend on 'pytz'.

Closes googleapis#533.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tseaver tseaver

Labels
api: storage Issues related to the googleapis/python-storage API. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: drop use of 'pytz' in tests / examples googleapis/python-storage
1 participant
@tseaver