test: support inline-begin in mock server #1271
Merged
+105
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
olavloite
requested review from
aakashanandg
and removed request for
harshachinta
| partial.values.extend(row) | ||
| partials.append(partial) | ||
| partials[len(partials) - 1].stats = result.stats | ||
| if started_transaction: | ||
| partials[0].metadata.transaction = started_transaction |
There was a problem hiding this comment.
Is there a specific reason we're including the transaction object details with the first partial result set?
There was a problem hiding this comment.
Yes, that is how the Spanner API works:
- The first
PartialResultSetin a stream should always contain the metadata for the query result. The remainingPartialResultSets will not have this field set. - If the request (e.g. the
ExecuteSqlRequest) contained aBeginTransactionoption, then the metadata should also include the transaction ID of the transaction that was started as a side-effect of executing the request.
See https://cloud.google.com/spanner/docs/reference/rpc/google.spanner.v1#google.spanner.v1.TransactionSelector for a bit more background information.
aakashanandg
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for inline-begin in the mock server.