Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: create base class for mockserver tests #1255

Merged
merged 5 commits into from
Dec 5, 2024

Conversation

olavloite
Copy link
Contributor

@olavloite olavloite commented Dec 5, 2024

Move the boiler-plate code for mockserver tests to a separate class, so this can easily be re-used for other tests.

Move the boiler-plate code for mockserver tests to a separate
class, so this can easily be re-used for other tests.
@olavloite olavloite requested review from a team as code owners December 5, 2024 12:40
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Dec 5, 2024
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Dec 5, 2024
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Dec 5, 2024
@olavloite olavloite added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 5, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Dec 5, 2024
@olavloite olavloite removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 5, 2024
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Dec 5, 2024
@olavloite olavloite enabled auto-merge (squash) December 5, 2024 19:22
@olavloite olavloite merged commit 96da8e1 into main Dec 5, 2024
14 of 16 checks passed
@olavloite olavloite deleted the make-base-mock-server-test-class branch December 5, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants