Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(spanner): multi_scm issue in python release #1230

Merged
merged 1 commit into from
Nov 11, 2024
Merged

chore(spanner): multi_scm issue in python release #1230

merged 1 commit into from
Nov 11, 2024

Conversation

sakthivelmanii
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@sakthivelmanii sakthivelmanii requested review from a team as code owners November 11, 2024 11:33
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Nov 11, 2024
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Nov 11, 2024
@sakthivelmanii sakthivelmanii force-pushed the fix_multi_scm_release_issue branch from 58df912 to 1c24346 Compare November 11, 2024 11:35
@sakthivelmanii sakthivelmanii changed the title Fix multi_scm issue in python release fix(spanner): multi_scm issue in python release Nov 11, 2024
@harshachinta harshachinta changed the title fix(spanner): multi_scm issue in python release chore(spanner): multi_scm issue in python release Nov 11, 2024
@harshachinta harshachinta merged commit 6d64e9f into googleapis:main Nov 11, 2024
10 of 13 checks passed
@release-please release-please bot mentioned this pull request Nov 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshachinta harshachinta harshachinta approved these changes

Assignees

@asthamohta asthamohta

Labels
api: spanner Issues related to the googleapis/python-spanner API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sakthivelmanii @harshachinta @asthamohta