Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Introduce compatibility with native namespace packages #1036

Merged
merged 5 commits into from
Dec 1, 2023
Merged

feat: Introduce compatibility with native namespace packages #1036

merged 5 commits into from
Dec 1, 2023

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Nov 14, 2023

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Nov 14, 2023
@parthea parthea added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed size: m Pull request size is medium. labels Nov 14, 2023
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Nov 14, 2023
@parthea
Copy link
Contributor Author

parthea commented Nov 14, 2023

Adding do not merge as there is an upcoming release freeze. This should be merged after the release freeze ends on November 29th.

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Nov 30, 2023
@parthea parthea marked this pull request as ready for review November 30, 2023 19:15
@parthea parthea requested review from a team as code owners November 30, 2023 19:15
@parthea parthea removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 30, 2023
@parthea
Copy link
Contributor Author

parthea commented Nov 30, 2023

Presubmit is failing with

nox > coverage report --show-missing --fail-under=99
No source for code: '/tmp/pytest-of-root/pytest-0/test_namespace_package_compat0/google/cloud/othermod.py'.
nox > Command coverage report --show-missing --fail-under=99 failed with exit code 1
nox > Session cover failed.

@parthea parthea assigned parthea and unassigned harshachinta Nov 30, 2023
@parthea parthea merged commit 5d80ab0 into main Dec 1, 2023
19 of 20 checks passed
@parthea parthea deleted the migrate-to-native-namespace-packages branch December 1, 2023 11:08
@release-please release-please bot mentioned this pull request Dec 1, 2023
Merged
@harshachinta harshachinta mentioned this pull request Jan 16, 2024
Draft
@harshachinta
Copy link
Contributor

harshachinta commented Jan 16, 2024 •
edited
Loading

@parthea
Quick followup based on googleapis/python-spanner-sqlalchemy#375 (comment)

ModuleNotFoundError: No module named 'google.cloud.spanner_v1'

Will customers see some issue with latest release similar to how sqlalchemy repo was facing? Can you please help understand this change?

@parthea
Copy link
Contributor Author

parthea commented Jan 16, 2024

@harshachinta , Please see my response in googleapis/python-spanner-sqlalchemy#375 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohmayr ohmayr ohmayr approved these changes

Assignees

@parthea parthea

Labels
api: spanner Issues related to the googleapis/python-spanner API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parthea @harshachinta @ohmayr