fix: Table name should be quoted by back quotes (`) on DROP TABLE #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: spanner
olavloite
reviewed
Feb 5, 2024
| @@ -438,7 +438,7 @@ def visit_drop_table(self, drop_table, **kw): | |||
| for index in drop_table.element.indexes: | |||
| indexes += "DROP INDEX {};".format(self.preparer.quote(index.name)) | |||
|
|
|||
| return indexes + constrs + str(drop_table) | |||
| return indexes + constrs + super().visit_drop_table(drop_table) | |||
There was a problem hiding this comment.
Can we use the same strategy for quoting identifiers for all operations in this method (and probably also in the entire file). In this method, it seems that most identifiers are quoted using preparer.quote(..).
Example: "DROP INDEX {};".format(self.preparer.quote(index.name)). Should we do that here as well?
There was a problem hiding this comment.
self.preparer.quote (its a super class variable not overridden here) is the correct way as internally super().visit_drop_table() also calls self.preparer.quote
olavloite
approved these changes
Feb 6, 2024
ankiaga
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#349