Skip to content

Commit

Permalink
chore: fix build and lint errors
Browse files Browse the repository at this point in the history
  • Loading branch information
olavloite committed Oct 24, 2023
1 parent d2222d5 commit 94d6ec7
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
2 changes: 1 addition & 1 deletion google/cloud/sqlalchemy_spanner/sqlalchemy_spanner.py
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ def render_literal_value(self, value, type_):
generate a SQL statement.
"""
raw = ["\\", "'", '"', "\n", "\t", "\r"]
if type(value) == str and any(single in value for single in raw):
if isinstance(value, str) and any(single in value for single in raw):
value = 'r"""{}"""'.format(value)
return value
else:
Expand Down
5 changes: 5 additions & 0 deletions test/test_suite_20.py
Original file line number Diff line number Diff line change
Expand Up @@ -2495,6 +2495,11 @@ class IsOrIsNotDistinctFromTest(_IsOrIsNotDistinctFromTest):
pass


@pytest.mark.skip("Spanner doesn't bizarre characters in foreign key names")
class BizarroCharacterFKResolutionTest(fixtures.TestBase):
pass


class OrderByLabelTest(_OrderByLabelTest):
@pytest.mark.skip(
"Spanner requires an alias for the GROUP BY list when specifying derived "
Expand Down

0 comments on commit 94d6ec7

Please sign in to comment.