Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add constraints file #572

Merged
merged 7 commits into from
Jan 29, 2021
Merged

chore: add constraints file #572

merged 7 commits into from
Jan 29, 2021

Conversation

busunkim96
Copy link
Contributor

Add constraints file to test lower bounds. These files will not be used until the noxfile is changed in googleapis/synthtool#869.

@busunkim96 busunkim96 requested a review from a team as a code owner December 30, 2020 20:54
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner-django API. label Dec 30, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 30, 2020
@busunkim96 busunkim96 changed the title chore: add comnstraints file chore: add constraints file Dec 30, 2020
Copy link
Contributor

@c24t c24t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but same questions as in googleapis/python-spanner#203.

@c24t c24t merged commit dab4516 into master Jan 29, 2021
@c24t c24t deleted the add-constraints-file branch January 29, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner-django API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants