Skip to content
This repository has been archived by the owner on Sep 21, 2023. It is now read-only.

docs: users can self enroll retail search feature on cloud console #195

Merged
merged 2 commits into from
Mar 28, 2022

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Mar 25, 2022

  • Regenerate this pull request now.

docs: suggest search users not to send IP and use hashed user id
docs: deprecate request_id in ImportProductsRequest
docs: deprecate search dynamic_facet_spec and suggest to config on cloud console
docs: keep the API doc up-to-date with recent changes
feat: add new AddLocalInventories and RemoveLocalInventories APIs
feat: users cannot switch to empty default branch unless force override
feat: allow search users to skip validation for invalid boost specs
feat: support search personalization
feat: search returns applied control ids in the response

BEGIN_COMMIT_OVERRIDE
docs: users can self enroll retail search feature on cloud console

docs: suggest search users not to send IP and use hashed user id
docs: deprecate request_id in ImportProductsRequest
docs: deprecate search dynamic_facet_spec and suggest to config on cloud console
docs: keep the API doc up-to-date with recent changes
feat: add new AddLocalInventories and RemoveLocalInventories APIs
feat: users cannot switch to empty default branch unless force override
feat: allow search users to skip validation for invalid boost specs
feat: support search personalization
feat: search returns applied control ids in the response
END_COMMIT_OVERRIDE

PiperOrigin-RevId: 437355889

Source-Link: googleapis/googleapis@4d00815

Source-Link: https://github.com/googleapis/googleapis-gen/commit/b2b798247d46c932737cf689744a827fae7e5313
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJiNzk4MjQ3ZDQ2YzkzMjczN2NmNjg5NzQ0YTgyN2ZhZTdlNTMxMyJ9

docs: suggest search users not to send IP and use hashed user id
docs: deprecate request_id in ImportProductsRequest
docs: deprecate search dynamic_facet_spec and suggest to config on cloud console
docs: keep the API doc up-to-date with recent changes
feat: add new AddLocalInventories and RemoveLocalInventories APIs
feat: users cannot switch to empty default branch unless force override
feat: allow search users to skip validation for invalid boost specs
feat: support search personalization
feat: search returns applied control ids in the response

PiperOrigin-RevId: 437355889

Source-Link: googleapis/googleapis@4d00815

Source-Link: https://github.com/googleapis/googleapis-gen/commit/b2b798247d46c932737cf689744a827fae7e5313
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJiNzk4MjQ3ZDQ2YzkzMjczN2NmNjg5NzQ0YTgyN2ZhZTdlNTMxMyJ9
@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners March 25, 2022 23:55
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 25, 2022
@product-auto-label product-auto-label bot added the api: retail Issues related to the googleapis/python-retail API. label Mar 25, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 25, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 25, 2022
@snippet-bot
Copy link

snippet-bot bot commented Mar 25, 2022

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner March 25, 2022 23:57
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 25, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 25, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 25, 2022
from google.cloud.retail_v2.types.common import PriceInfo
from google.cloud.retail_v2.types.common import Promotion
Copy link
Contributor

@parthea parthea Mar 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change (It would require users to update their code). Adding do not merge label while I confirm that we want to introduce a breaking change. If so , I need to check with the team on whether we should bump the major version. Another option is to roll back the breaking change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Anthonios! I'm aware that this might be a breaking change. But there is currently only one customer using this field and we will communicate with them with this update.
The major reason behind this is that we're planning to update promotion as a new resource in the future so it's better to update it sooner than later. We may bump the major version if that may help mitigate the risks.

@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 26, 2022
@parthea parthea changed the title docs: users can self enroll retail search feature on cloud console [Do not merge] docs: users can self enroll retail search feature on cloud console Mar 26, 2022
@parthea
Copy link
Contributor

parthea commented Mar 28, 2022

Removing do not merge as there is currently only one customer using the field and the product team is in contact with that customer.

@parthea parthea removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 28, 2022
@parthea parthea changed the title [Do not merge] docs: users can self enroll retail search feature on cloud console docs: users can self enroll retail search feature on cloud console Mar 28, 2022
@parthea parthea added the automerge Merge the pull request once unit tests and other checks pass. label Mar 28, 2022
@parthea parthea requested a review from chenlei1216 March 28, 2022 18:35
@parthea parthea merged commit 8d61976 into main Mar 28, 2022
@parthea parthea deleted the owl-bot-copy branch March 28, 2022 23:23
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: retail Issues related to the googleapis/python-retail API. owl-bot-copy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants