Skip to content
This repository has been archived by the owner on Sep 21, 2023. It is now read-only.

chore(samples): add scripts to setup and teardown test resources #137

Merged
merged 11 commits into from
Jan 28, 2022

Conversation

t-karasova
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

parthea and others added 7 commits January 26, 2022 23:57
* chore: use gapic-generator-python 0.58.4

fix: provide appropriate mock values for message body fields

committer: dovs
PiperOrigin-RevId: 419025932

Source-Link: googleapis/googleapis@73da669

Source-Link: https://github.com/googleapis/googleapis-gen/commit/46df624a54b9ed47c1a7eefb7a49413cf7b82f98
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDZkZjYyNGE1NGI5ZWQ0N2MxYTdlZWZiN2E0OTQxM2NmN2I4MmY5OCJ9

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
* ci(python): run lint / unit tests / docs as GH actions

Source-Link: googleapis/synthtool@57be0cd
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ed1f9983d5a935a89fe8085e8bb97d94e41015252c5b6c9771257cf8624367e6

* add commit to trigger gh actions

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
@t-karasova t-karasova requested a review from a team as a code owner January 26, 2022 23:10
@product-auto-label product-auto-label bot added the api: retail Issues related to the googleapis/python-retail API. label Jan 26, 2022
@parthea parthea changed the title Retail Tutorials. Setup/Cleanup test resources chore(samples): add scripts to setup and teardown test resources Jan 27, 2022
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added minor nits, otherwise LGTM

samples/snippets/create_test_resources.py Outdated Show resolved Hide resolved
samples/snippets/remove_test_resources.py Outdated Show resolved Hide resolved
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Jan 27, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 27, 2022
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added concern about running tests concurrently

samples/snippets/create_test_resources.py Outdated Show resolved Hide resolved
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 28, 2022
@parthea parthea requested a review from a team as a code owner January 28, 2022 12:26
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Jan 28, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 28, 2022
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 28, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 28, 2022
@parthea parthea merged commit daa78d7 into googleapis:main Jan 28, 2022
t-karasova pushed a commit to t-karasova/python-retail that referenced this pull request Feb 9, 2022
* chore: update .repo-metadata.json (googleapis#125)

* chore: use python-samples-reviewers (googleapis#128)

* chore: use gapic-generator-python 0.58.4 (googleapis#127)

* chore: use gapic-generator-python 0.58.4

fix: provide appropriate mock values for message body fields

committer: dovs
PiperOrigin-RevId: 419025932

Source-Link: googleapis/googleapis@73da669

Source-Link: https://github.com/googleapis/googleapis-gen/commit/46df624a54b9ed47c1a7eefb7a49413cf7b82f98
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDZkZjYyNGE1NGI5ZWQ0N2MxYTdlZWZiN2E0OTQxM2NmN2I4MmY5OCJ9

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore(python): update release.sh to use keystore (googleapis#130)

build: switch to release-please for tagging

* chore(main): release 1.3.0 (googleapis#131)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* ci(python): run lint / unit tests / docs as GH actions (googleapis#132)

* ci(python): run lint / unit tests / docs as GH actions

Source-Link: googleapis/synthtool@57be0cd
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ed1f9983d5a935a89fe8085e8bb97d94e41015252c5b6c9771257cf8624367e6

* add commit to trigger gh actions

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>

* add setup/cleanup test resources scripts

* Update samples/snippets/remove_test_resources.py

Co-authored-by: Anthonios Partheniou <[email protected]>

* review comments fix

Co-authored-by: Anthonios Partheniou <[email protected]>
Co-authored-by: gcf-owl-bot[bot] <78513119+gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
t-karasova pushed a commit to t-karasova/python-retail that referenced this pull request Feb 9, 2022
* chore: update .repo-metadata.json (googleapis#125)

* chore: use python-samples-reviewers (googleapis#128)

* chore: use gapic-generator-python 0.58.4 (googleapis#127)

* chore: use gapic-generator-python 0.58.4

fix: provide appropriate mock values for message body fields

committer: dovs
PiperOrigin-RevId: 419025932

Source-Link: googleapis/googleapis@73da669

Source-Link: https://github.com/googleapis/googleapis-gen/commit/46df624a54b9ed47c1a7eefb7a49413cf7b82f98
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDZkZjYyNGE1NGI5ZWQ0N2MxYTdlZWZiN2E0OTQxM2NmN2I4MmY5OCJ9

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore(python): update release.sh to use keystore (googleapis#130)

build: switch to release-please for tagging

* chore(main): release 1.3.0 (googleapis#131)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* ci(python): run lint / unit tests / docs as GH actions (googleapis#132)

* ci(python): run lint / unit tests / docs as GH actions

Source-Link: googleapis/synthtool@57be0cd
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ed1f9983d5a935a89fe8085e8bb97d94e41015252c5b6c9771257cf8624367e6

* add commit to trigger gh actions

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>

* add setup/cleanup test resources scripts

* Update samples/snippets/remove_test_resources.py

Co-authored-by: Anthonios Partheniou <[email protected]>

* review comments fix

Co-authored-by: Anthonios Partheniou <[email protected]>
Co-authored-by: gcf-owl-bot[bot] <78513119+gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
t-karasova pushed a commit to tetiana-karasova/python-retail that referenced this pull request Feb 10, 2022
* chore: update .repo-metadata.json (googleapis#125)

* chore: use python-samples-reviewers (googleapis#128)

* chore: use gapic-generator-python 0.58.4 (googleapis#127)

* chore: use gapic-generator-python 0.58.4

fix: provide appropriate mock values for message body fields

committer: dovs
PiperOrigin-RevId: 419025932

Source-Link: googleapis/googleapis@73da669

Source-Link: https://github.com/googleapis/googleapis-gen/commit/46df624a54b9ed47c1a7eefb7a49413cf7b82f98
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDZkZjYyNGE1NGI5ZWQ0N2MxYTdlZWZiN2E0OTQxM2NmN2I4MmY5OCJ9

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore(python): update release.sh to use keystore (googleapis#130)

build: switch to release-please for tagging

* chore(main): release 1.3.0 (googleapis#131)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* ci(python): run lint / unit tests / docs as GH actions (googleapis#132)

* ci(python): run lint / unit tests / docs as GH actions

Source-Link: googleapis/synthtool@57be0cd
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ed1f9983d5a935a89fe8085e8bb97d94e41015252c5b6c9771257cf8624367e6

* add commit to trigger gh actions

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>

* add setup/cleanup test resources scripts

* Update samples/snippets/remove_test_resources.py

Co-authored-by: Anthonios Partheniou <[email protected]>

* review comments fix

Co-authored-by: Anthonios Partheniou <[email protected]>
Co-authored-by: gcf-owl-bot[bot] <78513119+gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
t-karasova pushed a commit to tetiana-karasova/python-retail that referenced this pull request Feb 10, 2022
* chore: update .repo-metadata.json (googleapis#125)

* chore: use python-samples-reviewers (googleapis#128)

* chore: use gapic-generator-python 0.58.4 (googleapis#127)

* chore: use gapic-generator-python 0.58.4

fix: provide appropriate mock values for message body fields

committer: dovs
PiperOrigin-RevId: 419025932

Source-Link: googleapis/googleapis@73da669

Source-Link: https://github.com/googleapis/googleapis-gen/commit/46df624a54b9ed47c1a7eefb7a49413cf7b82f98
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDZkZjYyNGE1NGI5ZWQ0N2MxYTdlZWZiN2E0OTQxM2NmN2I4MmY5OCJ9

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore(python): update release.sh to use keystore (googleapis#130)

build: switch to release-please for tagging

* chore(main): release 1.3.0 (googleapis#131)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* ci(python): run lint / unit tests / docs as GH actions (googleapis#132)

* ci(python): run lint / unit tests / docs as GH actions

Source-Link: googleapis/synthtool@57be0cd
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ed1f9983d5a935a89fe8085e8bb97d94e41015252c5b6c9771257cf8624367e6

* add commit to trigger gh actions

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>

* add setup/cleanup test resources scripts

* Update samples/snippets/remove_test_resources.py

Co-authored-by: Anthonios Partheniou <[email protected]>

* review comments fix

Co-authored-by: Anthonios Partheniou <[email protected]>
Co-authored-by: gcf-owl-bot[bot] <78513119+gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: retail Issues related to the googleapis/python-retail API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants