Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set stream_ack_deadline to max_duration_per_lease_extension or 60 s, set ack_deadline to min_duration_per_lease_extension or 10 s #760

Merged
merged 3 commits into from
Aug 11, 2022

Conversation

acocuzzo
Copy link
Contributor

@acocuzzo acocuzzo commented Aug 11, 2022

When max_duration_per_lease_extension is set and within the 10 - 600 secs, the stream_ack_deadline will be set to max_duration_per_lease_extension, otherwise it will be set to 60 seconds to match Java client library behavior.

When min_duration_per_lease_extension is set and within the 10 - 600 sec, the ack_deadline will be initialized with this value, otherwise it will default to 10 sec.

Fixes #758🦕

@acocuzzo acocuzzo requested review from a team as code owners August 11, 2022 00:21
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: pubsub Issues related to the googleapis/python-pubsub API. labels Aug 11, 2022
@acocuzzo acocuzzo changed the title fix: set default streaming_ack_deadline to 60 and make configurable fix: set stream_ack_deadline to max_duration_per_lease_extension or 60 s, set ack_deadline to min_duration_per_lease_extension or 10 s Aug 11, 2022
@acocuzzo acocuzzo added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 11, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 11, 2022
@acocuzzo acocuzzo added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 11, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 11, 2022
@acocuzzo acocuzzo merged commit 4444129 into googleapis:main Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set default stream_ack_deadline to 60 sec, or via max_duration_per_lease_extension
2 participants