Tests: Remove shared subscriptions across parallel tests #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
acocuzzo
changed the title
acocuzzo
changed the title
product-auto-label
bot
added
size: xl
This reverts commit 7359447.
product-auto-label
bot
added
size: l
acocuzzo
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
This reverts commit 6f384e2.
acocuzzo
added
the
kokoro:run
yoshi-kokoro
removed
the
kokoro:run
acocuzzo
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
acocuzzo
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
acocuzzo
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In samples/snippets/noxfile.py, tests are run in parallel if pytest-parallel is installed.
This resulted in tests failing in CI that did not fail locally. Because of the use of shared subscription names across tests running in parallel, some tests were deleting a subscription, while others were attempting to receive messages.
This PR removes all subscription test fixtures that created and deleted subscriptions that were reused across tests in samples/snippets/subscriber_test.py, instead repeating the creation logic within each test, with a different subscription name per test, to allow tests to run in parallel without failures.
Also includes unrelated formatting changes due to linting changes.
Fixes #668🦕