Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add emulator support to schema service #658

Merged
merged 17 commits into from
May 10, 2022
Merged

fix: Add emulator support to schema service #658

merged 17 commits into from
May 10, 2022

Conversation

acocuzzo
Copy link
Contributor

@acocuzzo acocuzzo commented Apr 15, 2022 •
edited
Loading

Adding schema_service/client.py to clients_to_patch in owlbot.py to add emulator support.

Fixes #647🦕

@acocuzzo acocuzzo requested review from a team as code owners April 15, 2022 15:49
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: pubsub Issues related to the googleapis/python-pubsub API. labels Apr 15, 2022
@acocuzzo acocuzzo added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 15, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 15, 2022
@acocuzzo acocuzzo added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 15, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 15, 2022
@acocuzzo acocuzzo marked this pull request as draft April 15, 2022 15:52
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: xs Pull request size is extra small. labels Apr 18, 2022
@acocuzzo acocuzzo added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 18, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 18, 2022
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xl Pull request size is extra large. labels Apr 18, 2022
@acocuzzo acocuzzo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 18, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 18, 2022
@acocuzzo acocuzzo changed the title fix: add emulator support to schema service fix: Add emulator support to schema service Apr 18, 2022
@googleapis googleapis deleted a comment from snippet-bot bot Apr 18, 2022
@acocuzzo acocuzzo added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 20, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 20, 2022
@acocuzzo acocuzzo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 21, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 21, 2022
@acocuzzo acocuzzo marked this pull request as ready for review April 21, 2022 20:39
@acocuzzo acocuzzo requested a review from a team as a code owner April 21, 2022 20:39
@acocuzzo acocuzzo requested a review from parthea April 21, 2022 20:39
pradn
pradn approved these changes May 10, 2022
View reviewed changes
Copy link
Contributor

@pradn pradn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider putting import grpc back where it was. Otherwise, looks good.

@acocuzzo acocuzzo merged commit 1a07d7c into googleapis:main May 10, 2022
@release-please release-please bot mentioned this pull request May 10, 2022
Merged
@release-please release-please bot mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pradn pradn pradn approved these changes

@parthea parthea Awaiting requested review from parthea parthea was automatically assigned from googleapis/python-samples-owners

Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Schema api not supporting pubsub emulator
3 participants
@acocuzzo @pradn @yoshi-kokoro