Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): move libcst to extras #585

Merged
merged 2 commits into from
Feb 15, 2022
Merged

fix(deps): move libcst to extras #585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52e6d00
fix(deps): move libcst to extras
busunkim96 Feb 14, 2022
5f26a93
Merge branch 'main' into libcst-extra
busunkim96 Feb 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions UPGRADING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ The 2.0.0 release requires Python 3.6+.
Almost all methods that send requests to the backend expect request objects. We
provide a script that will convert most common use cases.

* Install the library
* Install the library with the `libcst` extra.

```py
python3 -m pip install google-cloud-pubsub
python3 -m pip install google-cloud-pubsub[libcst]
```

* The script `fixup_pubsub_v1_keywords.py` is shipped with the library. It expects
Expand Down
3 changes: 1 addition & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,10 @@
# Until this issue is closed
# https://github.com/googleapis/google-cloud-python/issues/10566
"google-api-core[grpc] >= 1.28.0, <3.0.0dev",
"libcst >= 0.3.10",
"proto-plus >= 1.7.1",
"grpc-google-iam-v1 >= 0.12.3, < 0.13dev",
]
extras = {}
extras = {"libcst": "libcst >= 0.3.10"}


# Setup boilerplate below this line.
Expand Down