-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
process: add type annotations check to CI runs #499
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Sep 17, 2021
product-auto-label
bot
added
the
api: pubsub
Issues related to the googleapis/python-pubsub API.
label
Sep 17, 2021
plamut
changed the title
process: add type checks to CI runs
process: add type annotations check to CI runs
Sep 17, 2021
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Sep 17, 2021
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Sep 17, 2021
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Sep 17, 2021
FWIW, the samples failure is flakiness, will re-run when this is ready to be merged. |
@pradn @anguillanneuf Friendly ping, this would be a useful addition, thanks! |
Closed
plamut
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Sep 24, 2021
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Sep 24, 2021
plamut
added
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
kokoro:run
Add this label to force Kokoro to re-run the tests.
labels
Sep 24, 2021
yoshi-kokoro
removed
kokoro:run
Add this label to force Kokoro to re-run the tests.
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
labels
Sep 24, 2021
plamut
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Sep 24, 2021
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Sep 24, 2021
busunkim96
approved these changes
Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: pubsub
Issues related to the googleapis/python-pubsub API.
cla: yes
This human has signed the Contributor License Agreement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #477.
To verify, examine the CI logs and check that the
pytype
session has indeed run.PR checklist: