Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump test coverage to 100% #364

Merged
merged 7 commits into from
Apr 9, 2021
Merged

chore: bump test coverage to 100% #364

merged 7 commits into from
Apr 9, 2021

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Apr 3, 2021 •
edited
Loading

Closes #363.
Closes #367.

This PR fixes the code lines/paths that currently drag the overall coverage down.

The majority are error code paths in tests that are never executed if a test passes, and abstract methods that we do not explicitly test if they indeed raise NotImplementedError. The rest is some unused code and a few other misc. cleanups.

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

plamut added 6 commits April 3, 2021 10:45
@plamut
Exclude unreachable test lines from coverage
1ac9107
@plamut
Skip abstract methods and unused code in coverage
c04041c
@plamut
Assure batch ERROR status is actually set in test
88c4bdd 
One of the tests attempted to set an ERROR status on a batch, but
that batch was a mock, meaning that setting a status had no effect.

If there was a bug in the corresponding code path, the test would
probably not catch it, as that code patch would not be taken.
@plamut
Skip code branch that is currently not taken
d614c59
@plamut
Silence deprecation warning in two gapic tests
830003c 
The tests for flattened arguments to the sync pull() method
hit a code path that emits a deprecation warning, but that
warning is expected and should not clutter the test output.
@plamut
Raise required unit test coverage to 100%
587d033
@plamut plamut requested a review from a team as a code owner April 3, 2021 09:44
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Apr 3, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 3, 2021
@tseaver tseaver requested a review from jimfulton April 5, 2021 18:17
jimfulton
jimfulton suggested changes Apr 7, 2021
View reviewed changes
google/cloud/pubsub_v1/publisher/flow_controller.py Outdated Show resolved Hide resolved
synth.py Show resolved Hide resolved
@plamut plamut requested a review from jimfulton April 8, 2021 08:16
@plamut plamut merged commit 5812018 into googleapis:master Apr 9, 2021
@plamut plamut deleted the bump-coverage branch April 9, 2021 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimfulton jimfulton jimfulton approved these changes

Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DeprecationWarnings in unit tests should be trapped / asserted Bump required unit test coverage to 100%
2 participants
@plamut @jimfulton