-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix streaming pull close test flakiness #361
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what flakiness this is fixing.
On my machine, the system test test_publish_large_messages
still fails with a timeout on this branch. Maybe that's not what this PR is intended to address.
@jimfulton It fixes the flakiness in unit tests. If a system test covering the same code is now flaky, too, we should investigate that as well, but it's a separate issue (that test depends on some assumption about how the backend works). Edit: Created an issue to track that. |
Oops, OK. :) |
Fixes #352.
Fixes #373.
This PR fixes unit test flakiness by waiting for the streaming pull manager shutdown thread to finish running before making any assertions.
PR checklist