Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: regenerate GAPIC layer with latest changes #345

Merged
merged 1 commit into from
Apr 2, 2021
Merged

chore: regenerate GAPIC layer with latest changes #345

merged 1 commit into from
Apr 2, 2021

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Mar 23, 2021

Fixes #344.
Fixes #303.

This PR fixes the false alarm synth error, and brings in the latest changes to the generated code, including the correct default timeouts for publisher methods.

PR checklist

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut plamut requested a review from a team as a code owner March 23, 2021 10:27
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Mar 23, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 23, 2021
This was referenced Mar 23, 2021
Closed
Closed
Closed
@meredithslota meredithslota requested a review from pradn March 30, 2021 20:19
pradn
pradn approved these changes Apr 1, 2021
View reviewed changes
Copy link
Contributor

@pradn pradn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@plamut plamut merged commit 469ebaa into googleapis:master Apr 2, 2021
@plamut plamut deleted the iss-344 branch April 2, 2021 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pradn pradn pradn approved these changes

Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Synthesis failed for python-pubsub Default deadline for publish does not match expectations
2 participants
@plamut @pradn