Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: regenerate the client lib to pick new mtls env #197

Merged
merged 3 commits into from
Sep 18, 2020
Merged

Conversation

arithmetic1728
Copy link
Contributor

ran synthtool to update the auto-generated layer

@arithmetic1728 arithmetic1728 requested review from a team as code owners September 16, 2020 18:13
@arithmetic1728 arithmetic1728 requested review from dinagraves and removed request for a team September 16, 2020 18:13
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 16, 2020
@arithmetic1728
Copy link
Contributor Author

@anguillanneuf Could you also take a look at this PR? Oneplatform team needs this feature in the auto-generated client code for DCA testing. Thanks!

@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Sep 17, 2020
@arithmetic1728 arithmetic1728 merged commit 9667ef1 into master Sep 18, 2020
@arithmetic1728 arithmetic1728 deleted the sijun branch September 18, 2020 21:10
@anguillanneuf
Copy link
Contributor

@plamut Just as a heads-up, we need to release a new version on Monday 9/21 to facilitate MTLS testing. I can get to it if you can't. My guess is you will. :)

@plamut
Copy link
Contributor

plamut commented Sep 21, 2020

@anguillanneuf OK, I'll open a release PR shortly, just waiting to merge a fix to one of the samples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants