fix: convert all RPC error types to exceptions #170
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #163.
This PR fixes a problem when the underlying gRPC channel is wrapped into something and terminates with a reason that is not an instance of
grpc.RpcError
. The streaming pull manager now converts all reason types into anException
instance, fixing aTypeError
when aStreamingPullFuture
then tries to raise it.Still waiting for the reporter's confirmation that this is indeed what happens, but I found no other place in the code that could call
future.set_exception(...)
with a non-Exception argument.(probably also makes sense to merge #158 first so that we don't have to make yet another release before dropping Python 2)
PR checklist