-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
samples: publish with ordering keys #156
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new generated client will introduce quite a few incompatibilities (unless it's a microgenerator issue that will be fixed). Maybe first check if these changes also work on the #158 PR branch?
(the latter already contains the new generated client)
# subscription_id = "your-subscription-id" | ||
|
||
subscriber = pubsub_v1.SubscriberClient() | ||
topic_path = subscriber.topic_path(project_id, topic_id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
topic_path()
does not exist anymore on subscriber client, had to fix quite a few of these in #158. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a massive PR! Thank you for the heads-up! I will aim to merge this one after that one and the changes are in.
@anguillanneuf How urgent it is to get this in / publish it? If possible, we would like to avoid making a yet another "last" Python 2 release and potentially extra work on the PR transitioning the library to the microgenerator. |
@plamut Thanks for checking in with me. No need for another Python 2 release. I have not yet "published" the sample on Cloud site. Currently only the Java sample is. |
Add samples for publish with ordering keys. The test can't be run yet because the feature isn't released: