-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add OpenTelemetry support for Subscribe Side #1252
Commits on Sep 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 04c3881 - Browse repository at this point
Copy the full SHA 04c3881View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a679a5 - Browse repository at this point
Copy the full SHA 0a679a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 40a2996 - Browse repository at this point
Copy the full SHA 40a2996View commit details -
Configuration menu - View commit details
-
Copy full SHA for b10f2f6 - Browse repository at this point
Copy the full SHA b10f2f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 95a1d32 - Browse repository at this point
Copy the full SHA 95a1d32View commit details -
Modify SubscriberMessage to include opentelemetry data and include
SubscribeSpan information in the SubscriberMessage's Open Telemetry data
Configuration menu - View commit details
-
Copy full SHA for c556f99 - Browse repository at this point
Copy the full SHA c556f99View commit details -
Configuration menu - View commit details
-
Copy full SHA for f52fbac - Browse repository at this point
Copy the full SHA f52fbacView commit details -
Add Open Telemetry data to Ack, Modack, Nack request objects
* This is required for the Open Telemetry information to be percolated to the dispatcher which performs acks, nacks and modacks async. * The Open Telemetry data passed into the dispatcher will be used to add events such as ack, modack, nack end to the subscribe span
Configuration menu - View commit details
-
Copy full SHA for b5ab6bb - Browse repository at this point
Copy the full SHA b5ab6bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for a695c99 - Browse repository at this point
Copy the full SHA a695c99View commit details -
Add tests for ack and ack_with_response methods of Subscriber Message
* Both these methods should add the "ack start" event to the subscribe span
Configuration menu - View commit details
-
Copy full SHA for 694cfde - Browse repository at this point
Copy the full SHA 694cfdeView commit details -
Add tests for nack and nack_with_response methods of Subscriber Message
* Both these methods should add "nack start" events to the subscribe span
Configuration menu - View commit details
-
Copy full SHA for 27edc0f - Browse repository at this point
Copy the full SHA 27edc0fView commit details -
Add tests for modify_ack_deadline and modify_ack_deadline_with_response
* Both these methods should add the "modack start" event to the subscribe span
Configuration menu - View commit details
-
Copy full SHA for c1f0ad8 - Browse repository at this point
Copy the full SHA c1f0ad8View commit details -
Configuration menu - View commit details
-
Copy full SHA for e97b83c - Browse repository at this point
Copy the full SHA e97b83cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8189b12 - Browse repository at this point
Copy the full SHA 8189b12View commit details -
Configuration menu - View commit details
-
Copy full SHA for 48ffe54 - Browse repository at this point
Copy the full SHA 48ffe54View commit details -
Pass the OpenTelemetry data to the dispatcher when message is acked,
nacked or modacked
Configuration menu - View commit details
-
Copy full SHA for d40b676 - Browse repository at this point
Copy the full SHA d40b676View commit details -
Configuration menu - View commit details
-
Copy full SHA for 383ac2c - Browse repository at this point
Copy the full SHA 383ac2cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ce0cf8 - Browse repository at this point
Copy the full SHA 5ce0cf8View commit details
Commits on Sep 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5b21c93 - Browse repository at this point
Copy the full SHA 5b21c93View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b2020d - Browse repository at this point
Copy the full SHA 1b2020dView commit details
Commits on Sep 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 26a86ec - Browse repository at this point
Copy the full SHA 26a86ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for dbe1e50 - Browse repository at this point
Copy the full SHA dbe1e50View commit details -
Configuration menu - View commit details
-
Copy full SHA for ef0c391 - Browse repository at this point
Copy the full SHA ef0c391View commit details -
Configuration menu - View commit details
-
Copy full SHA for b71cf15 - Browse repository at this point
Copy the full SHA b71cf15View commit details -
Configuration menu - View commit details
-
Copy full SHA for da797cf - Browse repository at this point
Copy the full SHA da797cfView commit details -
Add subscription_id property to SubscribeOpenTelemetry
* This field will then be used for span names of spans like Process Span
Configuration menu - View commit details
-
Copy full SHA for a005057 - Browse repository at this point
Copy the full SHA a005057View commit details -
Configuration menu - View commit details
-
Copy full SHA for 47c9d9a - Browse repository at this point
Copy the full SHA 47c9d9aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8faa3cf - Browse repository at this point
Copy the full SHA 8faa3cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4189b22 - Browse repository at this point
Copy the full SHA 4189b22View commit details
Commits on Sep 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 06ce105 - Browse repository at this point
Copy the full SHA 06ce105View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5fa4773 - Browse repository at this point
Copy the full SHA 5fa4773View commit details -
Configuration menu - View commit details
-
Copy full SHA for f30c2c4 - Browse repository at this point
Copy the full SHA f30c2c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ae2418 - Browse repository at this point
Copy the full SHA 3ae2418View commit details
Commits on Sep 22, 2024
-
Move adding dropped event and ending subscriber span from
dispatcher.drop to leaser.maintain_leases * dispatcher.drop() is also called by ack, _retry_ack, nack and maintain_leases(when it wants to drop expired messages. * We only want to record the dropped event when the message is expired and hence dropped by the leaser
Configuration menu - View commit details
-
Copy full SHA for d1c870d - Browse repository at this point
Copy the full SHA d1c870dView commit details -
Move ack called subscribe span event from message.ack() to
dispatcher.ack() where the ack RPC is made
Configuration menu - View commit details
-
Copy full SHA for cb1f974 - Browse repository at this point
Copy the full SHA cb1f974View commit details -
Move nack start event from message.nack and message.nack_with_response
to dispatcher.modify_ack_deadline(deadline=0) when nack RPC is made
Configuration menu - View commit details
-
Copy full SHA for 7d6ea08 - Browse repository at this point
Copy the full SHA 7d6ea08View commit details -
Move modack start event from message.modify_ack_deadline/with response
to dispatcher.modify_ack_deadline()
Configuration menu - View commit details
-
Copy full SHA for e07fa4d - Browse repository at this point
Copy the full SHA e07fa4dView commit details -
Configuration menu - View commit details
-
Copy full SHA for c384466 - Browse repository at this point
Copy the full SHA c384466View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ba47ff - Browse repository at this point
Copy the full SHA 9ba47ffView commit details
Commits on Sep 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2410a4e - Browse repository at this point
Copy the full SHA 2410a4eView commit details -
Configuration menu - View commit details
-
Copy full SHA for b66fd19 - Browse repository at this point
Copy the full SHA b66fd19View commit details -
Configuration menu - View commit details
-
Copy full SHA for 54a88ba - Browse repository at this point
Copy the full SHA 54a88baView commit details -
Configuration menu - View commit details
-
Copy full SHA for 28a192a - Browse repository at this point
Copy the full SHA 28a192aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c8c5eb9 - Browse repository at this point
Copy the full SHA c8c5eb9View commit details
Commits on Sep 24, 2024
-
* Currently, subscribe_span is ended after modack end event is added to the subscribe_span. This should not happen, since subscribe_span should be ended only after ack,nack or drop, but not modack * Remove an extraneous modack start that was present in streaming_pull_manager.send_lease_modacks(). This is not required, since modack start and end events will anyways be added to the subscribe span in the dispatcher.modify_ack_deadline() method. * Replace the NamedTuple._replace() methods with creation of new NamedTuple ModackRequest items. This is because NamedTuple._replace() returns a new NamedTuple, rather than replacing the existing one. This results in the opentelemetry data not being plumbed down into the dispatcher.modify_ack_deadline_method.
Configuration menu - View commit details
-
Copy full SHA for 6ec7c35 - Browse repository at this point
Copy the full SHA 6ec7c35View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7936911 - Browse repository at this point
Copy the full SHA 7936911View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5874a96 - Browse repository at this point
Copy the full SHA 5874a96View commit details -
Configuration menu - View commit details
-
Copy full SHA for a791570 - Browse repository at this point
Copy the full SHA a791570View commit details -
Add links to nack spans in the subscribe span in
dispatcher.modify_ack_deadlin()
Configuration menu - View commit details
-
Copy full SHA for 3206c19 - Browse repository at this point
Copy the full SHA 3206c19View commit details -
Configuration menu - View commit details
-
Copy full SHA for 14250a1 - Browse repository at this point
Copy the full SHA 14250a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 815f2a3 - Browse repository at this point
Copy the full SHA 815f2a3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 94feeec - Browse repository at this point
Copy the full SHA 94feeecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5dd8fb8 - Browse repository at this point
Copy the full SHA 5dd8fb8View commit details -
Configuration menu - View commit details
-
Copy full SHA for b4fdd40 - Browse repository at this point
Copy the full SHA b4fdd40View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad13b59 - Browse repository at this point
Copy the full SHA ad13b59View commit details -
Split the subscription name at one place
* Addressing the review comment
Configuration menu - View commit details
-
Copy full SHA for 3977a6a - Browse repository at this point
Copy the full SHA 3977a6aView commit details