Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(samples): Update Topic with Kinesis Ingestion Settings #1123

Merged
merged 2 commits into from
Mar 15, 2024
Merged

docs(samples): Update Topic with Kinesis Ingestion Settings #1123

merged 2 commits into from
Mar 15, 2024

Conversation

mukund-ananthu
Copy link
Contributor

  1. Add code to demonstrate updating a topic with Kinesis Ingestion Settings
  2. IngestionDataSourceSettings were added as an attribute to Topic here

@mukund-ananthu mukund-ananthu requested review from a team as code owners March 14, 2024 15:12
@mukund-ananthu mukund-ananthu requested a review from iennae March 14, 2024 15:12
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Mar 14, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.
You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: pubsub Issues related to the googleapis/python-pubsub API. samples Issues that are directly related to samples. labels Mar 14, 2024
@mukund-ananthu mukund-ananthu requested a review from parthea March 14, 2024 15:18
@mukund-ananthu mukund-ananthu self-assigned this Mar 14, 2024
@mukund-ananthu mukund-ananthu force-pushed the updateTopic branch 3 times, most recently from 89590df to e01d3f1 Compare March 14, 2024 21:04
@mukund-ananthu mukund-ananthu added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 14, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 14, 2024
hongalex
hongalex reviewed Mar 14, 2024
View reviewed changes
samples/snippets/publisher.py Outdated
gcp_service_account: str,
) -> None:
"""Update Pub/Sub topic with AWS Kinesis Ingestion Settings."""
# [START pubsub_quickstart_update_topic_kinesis_ingestion]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this region tag

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@iennae iennae removed their request for review March 14, 2024 22:15
@mukund-ananthu
docs(samples): Update Topic with Kinesis Ingestion Settings
332ed86 
Add code to demonstrate updating a topic with Kinesis Ingestion Settings
IngestionDataSourceSettings were added as an attribute to Topic
[here](https://github.com/googleapis/googleapis/blob/65277ddce9caa1cfd1a0eb7ab67980fc73d20b50/google/pubsub/v1/pubsub.proto#L316)
hongalex
hongalex approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@hongalex hongalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed for Pub/Sub side, want review for Python style.

@mukund-ananthu
Copy link
Contributor Author

@parthea PTAL when free.

parthea
parthea approved these changes Mar 15, 2024
View reviewed changes
samples/snippets/publisher.py Outdated Show resolved Hide resolved
@mukund-ananthu mukund-ananthu merged commit e0e2d83 into main Mar 15, 2024
28 checks passed
@mukund-ananthu mukund-ananthu deleted the updateTopic branch March 15, 2024 17:56
@release-please release-please bot mentioned this pull request Mar 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hongalex hongalex hongalex approved these changes

@parthea parthea parthea approved these changes

Assignees

@mukund-ananthu mukund-ananthu

Labels
api: pubsub Issues related to the googleapis/python-pubsub API. samples Issues that are directly related to samples. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mukund-ananthu @parthea @hongalex @yoshi-kokoro