chore: add split repo templates #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
plamut
force-pushed
the
repo-templates
branch
from
6b5e53d to
dbc3fcf
Compare
plamut
commented
Jan 31, 2020
| session.install("-e", local_dep) | ||
| session.install("-e", "../test_utils/") | ||
| # session.install("-e", "../test_utils/") | ||
| session.install("-e", "test_utils") |
There was a problem hiding this comment.
This was needed, because test_utils cannot be placed "one level up", as synth.py is already at the root level.
I intentionally left the old path just commented out (as apposed to removing it) to remind us that we need to update the noxfile template after the repo split is done.
busunkim96
approved these changes
Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is "step 6 - Add Repo Templates" of the repo split procedure.
Not entirely sure if all
test_utilsfiles are needed, please check (removed just the egg-info metadata).