Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--use-keywords switch does not look to be supported #630

Closed
nshraddha28 opened this issue Mar 30, 2022 · 4 comments · Fixed by #635
Closed

--use-keywords switch does not look to be supported #630

nshraddha28 opened this issue Mar 30, 2022 · 4 comments · Fixed by #635
Assignees
@anguillanneuf
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. type: question Request for information or clarification. Not an issue.

Comments

@nshraddha28
Copy link

nshraddha28 commented Mar 30, 2022 •
edited
Loading

The GCP public document mentions use of --use-keywords to generate flattened keyword parameters instead of a request dictionary. However when a customer tried to use it, it says its not supported.

Looking at the github code history, it was added in #208 and removed in #253. Want to confirm if the document was not updated or was this an accidental change?

Thanks!
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Mar 30, 2022
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Mar 31, 2022
@meredithslota meredithslota added type: question Request for information or clarification. Not an issue. and removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Apr 4, 2022
@meredithslota
Copy link
Contributor

@anguillanneuf or @pradn — do you recall the context for this change?

@pradn
Copy link
Contributor

pradn commented Apr 5, 2022

The option was removed in https://github.com/googleapis/python-pubsub/pull/253/files#diff-1ecfff2217a5265afd2bdcf0cf05cda3d1cbb254e005f91c6fa0c7cb8a82d6ec. But we didn't update the docs. We should.

This is the autosynth commit where the change was made. It doesn't have further context. 0333f76

pradn added a commit that referenced this issue Apr 5, 2022
@pradn
Remove mention of obsolete --use-keywords in version 2.0 migration doc
8ce28c5 
Fixes #630
@pradn pradn mentioned this issue Apr 5, 2022
Merged
@nshraddha28
Copy link
Author

Is there a reason why this flag was removed?

@pradn
Copy link
Contributor

pradn commented Apr 7, 2022

It was removed b/c the upstream code generator doesn't have this flag. The upstream version always overrides this repo's version.

To put it another way, we try to keep these scripts the same across languages and this flag was a custom flag for just this library.

anguillanneuf added a commit that referenced this issue Apr 11, 2022
@pradn @meredithslota
@acocuzzo @anguillanneuf
Remove mention of obsolete --use-keywords in version 2.0 migration doc (
792c565 
#635)

Fixes #630

Co-authored-by: meredithslota <[email protected]>
Co-authored-by: Anna Cocuzzo <[email protected]>
Co-authored-by: Tianzi Cai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anguillanneuf anguillanneuf

Labels
api: pubsub Issues related to the googleapis/python-pubsub API. type: question Request for information or clarification. Not an issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove mention of obsolete --use-keywords in version 2.0 migration doc googleapis/python-pubsub
5 participants
@pradn @meredithslota @anguillanneuf @yoshi-automation @nshraddha28