Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new client options #166

Closed
busunkim96 opened this issue Jul 22, 2020 · 2 comments · Fixed by #190
Closed

Implement new client options #166

busunkim96 opened this issue Jul 22, 2020 · 2 comments · Fixed by #190
Assignees
@cguardia
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@busunkim96
Copy link
Contributor

busunkim96 commented Jul 22, 2020 •
edited
Loading

Add support for the three new client_options quota_project_id, scopes, and credentials_file. These options are implemented on the mirogenerator, so the completion of the migration may automatically fulfill this.

https://googleapis.dev/python/google-api-core/latest/client_options.html
@busunkim96 busunkim96 transferred this issue from googleapis/google-cloud-python Jul 22, 2020
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Jul 22, 2020
@busunkim96 busunkim96 added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Jul 22, 2020
@busunkim96 busunkim96 changed the title Implement new client options for Pub/Sub Implement new client options Jul 22, 2020
@meredithslota
Copy link
Contributor

@plamut is working on the microgenerator pieces so assigning to him to look into.

@plamut
Copy link
Contributor

plamut commented Aug 4, 2020

Hmm... looking at the code, the publisher client does not even pass client_options to the underlying GAPIC client, because it takes them out of kwargs and never puts them back (kwargs are passed to the GAPIC client). The only thing used is target passed to the created GRPC channel a few lines below.

We need to fix that by keeping client_options in kwargs (both in publisher and subscriber), but other than that the new options should be supported out of the box after we migrate to microgenerator.

@plamut plamut assigned cguardia and unassigned plamut Sep 10, 2020
cguardia added a commit to cguardia/python-pubsub that referenced this issue Sep 14, 2020
@cguardia
fix: pass client options to publisher and subscriber clients (googlea…
923c4d8 
…pis#166)
@cguardia cguardia mentioned this issue Sep 14, 2020
Merged
3 tasks
plamut added a commit that referenced this issue Sep 14, 2020
@cguardia @plamut
fix: pass client options to publisher and subscriber clients (#166) (#…
049ae7d 
…190)

Co-authored-by: Peter Lamut <[email protected]>
@dependabot dependabot bot mentioned this issue Mar 11, 2021
Closed
@release-please release-please bot mentioned this issue Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cguardia cguardia

Labels
api: pubsub Issues related to the googleapis/python-pubsub API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: pass client options to publisher and subscriber clients (#166) cguardia/python-pubsub
4 participants
@cguardia @plamut @meredithslota @busunkim96