fix: batch at most 1,000 ack ids per request

googleapis · Oct 8, 2022 · b77d5f9 · b77d5f9
1 parent 9c79a1f
commit b77d5f9
Showing 1 changed file with 1 addition and 9 deletions.
diff --git a/google/cloud/pubsub_v1/subscriber/_protocol/dispatcher.py b/google/cloud/pubsub_v1/subscriber/_protocol/dispatcher.py
@@ -59,16 +59,8 @@
 """The maximum amount of time in seconds to wait for additional request items
 before processing the next batch of requests."""
 
-_ACK_IDS_BATCH_SIZE = 2500
+_ACK_IDS_BATCH_SIZE = 1000
 """The maximum number of ACK IDs to send in a single StreamingPullRequest.
-
-The backend imposes a maximum request size limit of 524288 bytes (512 KiB) per
-acknowledge / modifyAckDeadline request. ACK IDs have a maximum size of 164
-bytes, thus we cannot send more than o 524288/176 ~= 2979 ACK IDs in a single
-StreamingPullRequest message.
-
-Accounting for some overhead, we should thus only send a maximum of 2500 ACK
-IDs at a time.
 """
 
 _MIN_EXACTLY_ONCE_DELIVERY_ACK_MODACK_RETRY_DURATION_SECS = 1