fix: Typecheck errors in samples/snippets/subscriber.py

googleapis · Jun 7, 2024 · 0b19502 · 0b19502
1 parent cfd7926
commit 0b19502
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/samples/snippets/mypy.ini b/samples/snippets/mypy.ini
@@ -4,5 +4,7 @@ strict = True
 exclude = noxfile\.py
 warn_unused_configs = True
 
-[mypy-avro.*,backoff,flaky]
+; Ignore errors caused due to missing library stubs or py.typed marker
+; Refer https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-library-stubs-or-py-typed-marker
+[mypy-avro.*,backoff,flaky,google.cloud.*]
 ignore_missing_imports = True
diff --git a/samples/snippets/subscriber.py b/samples/snippets/subscriber.py
@@ -528,7 +528,7 @@ def update_subscription_with_dead_letter_policy(
     )
 
     with subscriber:
-        subscription_after_update = subscriber.update_subscription(
+        subscription_after_update: gapic_types.Subscription = subscriber.update_subscription(
             request={"subscription": subscription, "update_mask": update_mask}
         )
 
@@ -573,7 +573,7 @@ def remove_dead_letter_policy(
     )
 
     with subscriber:
-        subscription_after_update = subscriber.update_subscription(
+        subscription_after_update: gapic_types.Subscription = subscriber.update_subscription(
             request={"subscription": subscription, "update_mask": update_mask}
         )