Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement expando model #99

Merged
merged 2 commits into from
May 29, 2019
Merged

implement expando model #99

merged 2 commits into from
May 29, 2019

Conversation

cguardia
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 27, 2019
chrisrossi
chrisrossi approved these changes May 29, 2019
View reviewed changes
Copy link
Contributor

@chrisrossi chrisrossi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good. Thanks!

src/google/cloud/ndb/model.py Outdated
else:
prop = GenericProperty(
name,
repeated=isinstance(value, list),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allow tuple as well?

@cguardia cguardia merged commit 6c06c10 into googleapis:master May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisrossi chrisrossi chrisrossi approved these changes

@andrewsg andrewsg Awaiting requested review from andrewsg

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cguardia @chrisrossi @googlebot