-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement LocalStructuredProperty #93
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Signed CLA. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Thank you for your kind contribution, and especially thank you for signing the CLA and including tests. This PR touches some code in active development, so we may need a few days to integrate it and avoid conflicts. |
Thanks a lot, and sorry for the late response. I think it's OK that it is stored as a blob value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'll accept the PR as is and add system tests later on.
PR for implementation of LocalStructuredProperty.
Discussion
I've found a different behavior between this PR and google.appengine.ext.ndb implementation.
LocalStructuredProperty inherits BlobProperty and use
pb.SerializePartialToString()
in Property._to_base_type both in google.appengine.ext and this.But when I see stored properties in cloud console, one with google.appengine.ext is stored as an embedded entity value, while this implementation results to a blob value.
Maybe
_db_set_uncompressed_meaning
is the cause? I haven't found the exact reason.If this difference matters, I'll dig in more.