Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement LocalStructuredProperty #93

Merged
merged 2 commits into from
May 17, 2019
Merged

Implement LocalStructuredProperty #93

merged 2 commits into from
May 17, 2019

Conversation

takashi8
Copy link
Contributor

PR for implementation of LocalStructuredProperty.

Discussion

I've found a different behavior between this PR and google.appengine.ext.ndb implementation.
LocalStructuredProperty inherits BlobProperty and use pb.SerializePartialToString() in Property._to_base_type both in google.appengine.ext and this.
But when I see stored properties in cloud console, one with google.appengine.ext is stored as an embedded entity value, while this implementation results to a blob value.

Maybe _db_set_uncompressed_meaning is the cause? I haven't found the exact reason.
If this difference matters, I'll dig in more.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label May 11, 2019
@takashi8
Copy link
Contributor Author

Signed CLA.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels May 11, 2019
@andrewsg
Copy link
Contributor

Thank you for your kind contribution, and especially thank you for signing the CLA and including tests. This PR touches some code in active development, so we may need a few days to integrate it and avoid conflicts.

@cguardia cguardia mentioned this pull request May 17, 2019
@cguardia
Copy link
Contributor

Thanks a lot, and sorry for the late response. I think it's OK that it is stored as a blob value.

@cguardia cguardia self-requested a review May 17, 2019 20:08
Copy link
Contributor

@cguardia cguardia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'll accept the PR as is and add system tests later on.

@cguardia cguardia merged commit 89b6850 into googleapis:master May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants