Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(CONTRIBUTING): Note the need for Redis/Memcached env vars in tests #838

Merged
merged 3 commits into from
Nov 17, 2022
Merged

docs(CONTRIBUTING): Note the need for Redis/Memcached env vars in tests #838

merged 3 commits into from
Nov 17, 2022
+6 −0

Conversation

rwhogg
Copy link
Contributor

@rwhogg rwhogg commented Nov 16, 2022

Fixes #836

@rwhogg rwhogg requested review from a team as code owners November 16, 2022 21:04
@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/python-ndb API. label Nov 16, 2022
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 16, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 16, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 16, 2022
@meredithslota meredithslota enabled auto-merge (squash) November 17, 2022 01:17
@meredithslota meredithslota added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 17, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 17, 2022
@meredithslota meredithslota merged commit 19f8415 into googleapis:main Nov 17, 2022
@release-please release-please bot mentioned this pull request Nov 17, 2022
Merged
@rwhogg rwhogg deleted the note-test-env-vars branch November 17, 2022 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthea parthea parthea approved these changes

Assignees
No one assigned
Labels
api: datastore Issues related to the googleapis/python-ndb API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document requirement of Redis/Memcached for running all the unit tests
4 participants
@rwhogg @parthea @meredithslota @yoshi-kokoro