docs: remove line about Python 2.7 being unsupported #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: datastore
rwhogg
force-pushed
the
remove-py2-unsupported-comment
branch
5 times, most recently
from
1cfc77a to
8b79bde
Compare
leahecole
approved these changes
Oct 19, 2022
leahecole
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
|
How does this change the code samples referenced above this line? https://github.com/googleapis/python-ndb/blob/main/docs/migrating.rst#ndbutils Are the utils fully functional in 2.7? |
rwhogg
force-pushed
the
remove-py2-unsupported-comment
branch
2 times, most recently
from
0649371 to
52ea0e0
Compare
|
That code snippet will still work in both Py2 and Py3 (ignoring that it had a minor syntax error which I've now corrected). Originally, I've adjusted the wording to reflect this. |
leahecole
approved these changes
Oct 21, 2022
According to the README and setup.py, we do support Python 2.7. Also clarify that the utils module and its positional decorator do still exist and does work in both Py2 and Py3
rwhogg
force-pushed
the
remove-py2-unsupported-comment
branch
from
21bc207 to
ad3e9cc
Compare
gcf-owl-bot
bot
removed
the
owlbot:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the README and setup.py, we do support Python 2.7
BEGIN_COMMIT_OVERRIDE
chore: remove line about Python 2.7 being unsupported
END_COMMIT_OVERRIDE