Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove reference to CircleCI in CONTRIBUTING.rst #806

Merged
merged 1 commit into from
Oct 18, 2022
Merged

chore: Remove reference to CircleCI in CONTRIBUTING.rst #806

merged 1 commit into from
Oct 18, 2022

Conversation

rwhogg
Copy link
Contributor

@rwhogg rwhogg commented Oct 6, 2022

That file was deleted in #687

@rwhogg rwhogg requested review from a team and andrewsg as code owners October 6, 2022 15:12
@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/python-ndb API. label Oct 6, 2022
dandhlee
dandhlee approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

(docs triggers a new release, this is internal so chore or cleanup would be a better prefix)

@dandhlee dandhlee changed the title docs: Remove reference to CircleCI in CONTRIBUTING.rst chore: Remove reference to CircleCI in CONTRIBUTING.rst Oct 6, 2022
@dandhlee dandhlee added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 6, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 6, 2022
@rwhogg
Copy link
Contributor Author

rwhogg commented Oct 6, 2022

I opened #807 to try and fix that docs-presubmit issue

@dandhlee
Copy link
Contributor

dandhlee commented Oct 6, 2022

It's an optional presubmit so it's fine for this PR to merge.

@dandhlee dandhlee added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 6, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 6, 2022
@rwhogg rwhogg force-pushed the remove-circleci-reference branch from c6c0680 to ce03571 Compare October 17, 2022 18:55
@rwhogg rwhogg force-pushed the remove-circleci-reference branch from ce03571 to ef629b9 Compare October 18, 2022 14:34
@rwhogg
Copy link
Contributor Author

rwhogg commented Oct 18, 2022

@dandhlee can we merge this?

@dandhlee dandhlee added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. automerge Merge the pull request once unit tests and other checks pass. labels Oct 18, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 18, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 18, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit aecd927 into googleapis:main Oct 18, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 18, 2022
@rwhogg rwhogg deleted the remove-circleci-reference branch June 22, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dandhlee dandhlee dandhlee approved these changes

@andrewsg andrewsg Awaiting requested review from andrewsg

Assignees
No one assigned
Labels
api: datastore Issues related to the googleapis/python-ndb API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rwhogg @dandhlee @yoshi-kokoro