test: fix flaky system test #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normally a unique namespace per test run is used to prevent different test runs from interfering with each other, but some tests are specifically for the default namespace. A discriminator is added to this test that allows us to naorrow the test query to only entities created in the current test run. Fixes googleapis#700
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: datastore
tseaver
reviewed
Jul 29, 2021
tests/system/test_query.py
Outdated
| @@ -377,6 +377,7 @@ def test_query_default_namespace_when_context_namespace_is_other( | |||
| class SomeKind(ndb.Model): | |||
| foo = ndb.IntegerProperty() | |||
| bar = ndb.StringProperty() | |||
| discriminator = ndb.StringProperty(default=namespace) | |||
There was a problem hiding this comment.
I'm a little confused as to why we're using namespace here to populate a field value: is it just because we know it to be unique per run? ISTM it would be clearer to create another value, using str(uuid.uuid4()) (or make a discriminator fixture which does that, if you are contemplating using the value in other testcases).
There was a problem hiding this comment.
Yes, that is the reason. I did waffle a bit on creating a new value for clarity versus using an already available value. You just made the clarity argument, so I'll switch to that. 9228131
tseaver
reviewed
Jul 29, 2021
tseaver
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally a unique namespace per test run is used to prevent different
test runs from interfering with each other, but some tests are
specifically for the default namespace. A discriminator is added to this
test that allows us to naorrow the test query to only entities created
in the current test run.
Fixes #700