Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): pin Sphinx==4.0.1 to fix docs build #698

Merged
merged 2 commits into from
Jul 28, 2021
Merged

chore(deps): pin Sphinx==4.0.1 to fix docs build #698

merged 2 commits into from
Jul 28, 2021

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jul 28, 2021

Closes #697.

@tseaver tseaver requested a review from chrisrossi July 28, 2021 18:32
@tseaver tseaver requested a review from andrewsg as a code owner July 28, 2021 18:32
@tseaver tseaver requested a review from a team July 28, 2021 18:32
@tseaver tseaver requested a review from a team as a code owner July 28, 2021 18:32
@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/python-ndb API. label Jul 28, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 28, 2021
@tseaver tseaver mentioned this pull request Jul 28, 2021
Merged
@dandhlee
Copy link
Contributor

Looks like we'll need #685 fixed first :/

chrisrossi
chrisrossi approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@chrisrossi chrisrossi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tseaver
Copy link
Contributor Author

tseaver commented Jul 28, 2021

@dandhlee The docs-presubmit job is not required.

@tseaver tseaver merged commit cf10a14 into master Jul 28, 2021
@tseaver tseaver deleted the 697-pin-sphinx-4.0.1 branch July 28, 2021 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisrossi chrisrossi chrisrossi approved these changes

@andrewsg andrewsg Awaiting requested review from andrewsg

Assignees
No one assigned
Labels
api: datastore Issues related to the googleapis/python-ndb API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sphinx > 4.0.1 breaks the docs build on master
3 participants
@tseaver @dandhlee @chrisrossi