Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement _prepare_for_put for StructuredProperty and LocalStructuredProperty. #221

Merged

Conversation

chrisrossi
Copy link
Contributor

@chrisrossi chrisrossi commented Oct 15, 2019

This was in the original code, but was overlooked when porting. Fixes #216

``LocalStructuredProperty``.

This was in the original code, but was overlooked when porting. Fixes
@chrisrossi chrisrossi requested a review from cguardia October 15, 2019 21:10
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 15, 2019
@chrisrossi chrisrossi requested review from cguardia and removed request for cguardia October 16, 2019 19:17
@chrisrossi
Copy link
Contributor Author

@cguardia Can you take a look at this?

Copy link
Contributor

@cguardia cguardia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Sorry I missed this before.

@chrisrossi chrisrossi merged commit dfd403f into googleapis:master Oct 17, 2019
@chrisrossi chrisrossi deleted the StructuredProperty._prepare_for_put branch October 17, 2019 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DateTimeProperty auto_now* is not set for StructuredProperty and LocalStructuredProperty
3 participants