Implement Query.map and Query.map_async.
#218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #210 .
A couple of features didn't come along with this implementation:
The
pass_batch_into_callbackargument: This wouldn't make a lot of sense in a query that uses an in-memory post filter and is impossible to do in MultiQuery (a logical query that merges the results of more than one Datastore query). While we could conceivably implement this in the case where a query maps directly onto a Datastore query, the details of the batching seem like an implementation detail that needn't really be exposed to the user. The utility of such a feature is uncertain, as well.The
merge_futureargument: This seems to be difficult enough to use that it likely isn't being used. The uses cases it seems to be targeting could probably be better handled by adding some user friendly methods, likeQuery.reduceorQuery.map_iter. At this time we are not aware of anyone using this or needing a work-around.