-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow class member values in projection and distinct queries #214
Conversation
…o be strings. This commit sets the converted properties so they may be used by the rest of the query.
…o be strings. This commit sets the converted properties so they may be used by the rest of the query.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
@chmoder it seems that a unit test is failing currently
|
@crwilcox, thank you. I have pushed changes to fix that along with a new test case to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thank you! I will merge once Kokoro awakens from its stupor and runs the tests.
Thanks Chris! I noticed the build failed due to lint checking. I ran black with kokoros build configuration and pushed that up as well. |
Yep, I was in the middle of writing a not about how to use "nox" to run "blacken" when you pushed that and made my note obsolete. Thanks! |
Thank you for your bugfix @chmoder ! |
Fixes #212 by setting the projection and distinct_on lists to their
string
type names. Before it converted them but did not set them.