Check context #211
Merged
Check context #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 27, 2019 10:08
already a running context for this thread. This is an attempt to root a possible weird concurrency problem. Related to googleapis#182.
googlebot
added
the
cla: yes
|
Are we confident we should raise an error here instead of just silently returning the existing context? |
No. Not 100%. But my instinct is to be more restrictive up front to prevent weird, hard to debug errors and if someone comes to us with a compelling use case we can try and figure out the best way to accommodate them. |
cguardia
approved these changes
Sep 27, 2019
There was a problem hiding this comment.
I agree with @chrisrossi that for now more restrictive is better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a top level context, check to make sure there isn't already a running context for this thread. This is an attempt to root a possible weird concurrency problem. Related to #182, but not a fix.