Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling fixes. #209

Merged
merged 2 commits into from
Sep 24, 2019
Merged

Spelling fixes. #209

merged 2 commits into from
Sep 24, 2019

Conversation

schwehr
Copy link
Contributor

@schwehr schwehr commented Sep 23, 2019

Found with:

codespell --version
1.14.0

Found with:

codespell --version
1.14.0
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 23, 2019
@cguardia cguardia self-requested a review September 24, 2019 04:48
Copy link
Contributor

@cguardia cguardia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for taking the time to fix these. We have automated spell check for docs, but not for comments, so this is very helpful.

@cguardia cguardia added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 24, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 24, 2019
@@ -330,7 +330,7 @@ def done_callback(yielded):
#
# It was tempting to call `_advance_tasklet` (`_help_tasklet_along`
# in Legacy) directly. Doing so, it has been found, can lead to
# exceeding the maximum recursion depth. Queing it up to run on the
# exceeding the maximum recursion depth. Queuing it up to run on the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The correction made the line length go over 79 characters, which is not accepted by the lint checker. Please move the last word here to the following line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in e239dc9

@cguardia
Copy link
Contributor

This is almost ready to merge, just need a single fix to be able to pass the lint checker. Thanks for the time you have taken to work on this.

@schwehr
Copy link
Contributor Author

schwehr commented Sep 24, 2019

Great! I will fix it later today.

@cguardia cguardia added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 24, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 24, 2019
@cguardia cguardia merged commit 851975a into googleapis:master Sep 24, 2019
@cguardia
Copy link
Contributor

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants