-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spelling fixes. #209
Spelling fixes. #209
Conversation
Found with: codespell --version 1.14.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for taking the time to fix these. We have automated spell check for docs, but not for comments, so this is very helpful.
google/cloud/ndb/tasklets.py
Outdated
@@ -330,7 +330,7 @@ def done_callback(yielded): | |||
# | |||
# It was tempting to call `_advance_tasklet` (`_help_tasklet_along` | |||
# in Legacy) directly. Doing so, it has been found, can lead to | |||
# exceeding the maximum recursion depth. Queing it up to run on the | |||
# exceeding the maximum recursion depth. Queuing it up to run on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The correction made the line length go over 79 characters, which is not accepted by the lint checker. Please move the last word here to the following line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in e239dc9
This is almost ready to merge, just need a single fix to be able to pass the lint checker. Thanks for the time you have taken to work on this. |
Great! I will fix it later today. |
Thanks a lot! |
Found with: