Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement use_datastore flag. #155

Merged
merged 1 commit into from
Aug 14, 2019
Merged

Implement use_datastore flag. #155

merged 1 commit into from
Aug 14, 2019

Conversation

chrisrossi
Copy link
Contributor

No description provided.

@chrisrossi chrisrossi requested review from cguardia and andrewsg August 9, 2019 16:49
@chrisrossi chrisrossi requested a review from crwilcox as a code owner August 9, 2019 16:49
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 9, 2019
@chrisrossi chrisrossi mentioned this pull request Aug 9, 2019
Closed
@chrisrossi
Copy link
Contributor Author

@cguardia Can you take a look?

cguardia
cguardia approved these changes Aug 13, 2019
View reviewed changes
Copy link
Contributor

@cguardia cguardia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this took some time. Looks very good.

@chrisrossi chrisrossi added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 13, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 13, 2019
@chrisrossi chrisrossi merged commit 9883379 into googleapis:master Aug 14, 2019
@chrisrossi chrisrossi deleted the use_datastore branch August 14, 2019 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cguardia cguardia cguardia approved these changes

@andrewsg andrewsg Awaiting requested review from andrewsg

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrisrossi @cguardia @googlebot @yoshi-kokoro