Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Kokoro publish-docs job #153

Merged
merged 9 commits into from
Aug 30, 2019
Merged

Fix Kokoro publish-docs job #153

merged 9 commits into from
Aug 30, 2019

Conversation

busunkim96
Copy link
Contributor

Library docs are available here: https://googleapis.dev/python/python-ndb/latest

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 8, 2019
Copy link
Contributor

@cguardia cguardia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@busunkim96 this looks good to go, sorry that we took so long to get to it. You will need to update the branch before merging. Thanks!

@busunkim96
Copy link
Contributor Author

@cguardia Thank you for bearing with me as I tweaked this :)

@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 23, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 23, 2019
@busunkim96
Copy link
Contributor Author

@andrewsg @cguardia

Two questions:

  1. It looks like a system test is failing. Should I try re-running Kokoro, or is this a known flaky test?
  2. I see a pypy unit test run that's getting skipped because pypy isn't installed in the Docker image. Should I add it to the Python image?

@cguardia
Copy link
Contributor

@busunkim96 hi. For 1), yes, we have some tests that depend on eventual consistency which fail every now and then, so rerunning the tests might fix it. For 2), I would defer to @andrewsg, but I believe if we have it in the configuration, it would be good to have it in the image.

@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 30, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 30, 2019
@busunkim96 busunkim96 merged commit 34b2517 into master Aug 30, 2019
@busunkim96 busunkim96 deleted the kokoro-publish-job branch August 30, 2019 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants