RedisCache #150
Merged
RedisCache #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Concrete implementation of ``GlobalCache`` which uses Redis.
googlebot
added
the
cla: yes
andrewsg
approved these changes
Aug 2, 2019
| """Implements :meth:`GlobalCache.delete`.""" | ||
| self.redis.delete(*keys) | ||
|
|
||
| def watch(self, keys): |
There was a problem hiding this comment.
Is watch() part of the original ndb's spec for caching? I don't understand how they made this work with the memcached api.
There was a problem hiding this comment.
watch and compare_and_swap are equivalent to using get and set in memcached using CAS tokens. Had to generalize the concept a bit to work with Redis. I also did away with the CAS acronym because it's a bit opaque. (I had to do some Googling when I first encountered it.)
|
Looks like we have a systems test error, but I'm unclear if it's affected by this PR or due to something else. |
chrisrossi
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
|
System test error seems to have been transient, related to eventual consistency. We've managed to squash most of those, but one still gets through sometimes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Concrete implementation of
GlobalCachewhich uses Redis. Thanks to @takashi8