Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_prepare_for_put was not being called at entity level #138

Merged
merged 1 commit into from
Jul 9, 2019
Merged

_prepare_for_put was not being called at entity level #138

merged 1 commit into from
Jul 9, 2019

Conversation

cguardia
Copy link
Contributor

@cguardia cguardia commented Jul 7, 2019

The _prepare_for_put method is implemented in various properties, but not in model, and there was no call to it before put.

@cguardia cguardia requested a review from chrisrossi July 7, 2019 15:05
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 7, 2019
chrisrossi
chrisrossi approved these changes Jul 8, 2019
View reviewed changes
Copy link
Contributor

@chrisrossi chrisrossi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you!

@cguardia cguardia merged commit 681a701 into googleapis:master Jul 9, 2019
@cguardia cguardia mentioned this pull request Jul 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisrossi chrisrossi chrisrossi approved these changes

@andrewsg andrewsg Awaiting requested review from andrewsg

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cguardia @chrisrossi @googlebot