Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix key property. #136

Merged
merged 2 commits into from
Jul 5, 2019
Merged

Fix key property. #136

merged 2 commits into from
Jul 5, 2019

Conversation

chrisrossi
Copy link
Contributor

Fixes #134.

@chrisrossi chrisrossi requested a review from cguardia July 5, 2019 16:35
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 5, 2019
@chrisrossi chrisrossi mentioned this pull request Jul 5, 2019
Closed
cguardia
cguardia approved these changes Jul 5, 2019
View reviewed changes
Copy link
Contributor

@cguardia cguardia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@chrisrossi chrisrossi merged commit 0d3697c into googleapis:master Jul 5, 2019
@chrisrossi chrisrossi deleted the key-property branch July 5, 2019 18:08
@blk-josecols blk-josecols mentioned this pull request Jan 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cguardia cguardia cguardia approved these changes

@andrewsg andrewsg Awaiting requested review from andrewsg

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ValueError: ('Unknown protobuf attr type', <class 'google.cloud.ndb.key.Key'>) when storing Key as value
3 participants
@chrisrossi @cguardia @googlebot