ndb.Expando properties load and save #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
cguardia
approved these changes
Jun 24, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are porting our py27 GAE project to py37 GAE and replacing built-in services to their gcloud library counterparts.
During writing exploration tests for python-ndb we found that Expando models properties are not loaded from datastore for existing models and also not saved for new ones.
Also in the case of repeated properties that contains None values, _BaseValue(value) raising an exception.
After investigation, we made some changes in _entity_from_ds_entity and _entity_to_ds_entity functions and currently expando properties loads and saves as expected.
Please review.